Signed-off-by: Nguyán ThÃi Ngác Duy <pclouds@xxxxxxxxx> --- Documentation/git-tag.txt | 11 ++++++++++- builtin/tag.c | 19 ++++++++++++++++--- 2 files changed, 26 insertions(+), 4 deletions(-) diff --git a/Documentation/git-tag.txt b/Documentation/git-tag.txt index 8b169e3..7a3ae28 100644 --- a/Documentation/git-tag.txt +++ b/Documentation/git-tag.txt @@ -12,7 +12,8 @@ SYNOPSIS 'git tag' [-a | -s | -u <key-id>] [-f] [-m <msg> | -F <file>] <tagname> [<commit> | <object>] 'git tag' -d <tagname>... -'git tag' [-n[<num>]] -l [--contains <commit>] [<pattern>] +'git tag' [-n[<num>]] -l [--[no-]column[=<options>[,<option>]*]] + [--contains <commit>] [<pattern>] 'git tag' -v <tagname>... DESCRIPTION @@ -71,6 +72,14 @@ OPTIONS List tags with names that match the given pattern (or all if no pattern is given). Typing "git tag" without arguments, also lists all tags. +--column:: + Show tags in columns. This option is only applicable if `git tag` is + used to list tags without annotation lines. + +--no-column:: + Show tags in a single list. This option is used to override core.columns + if set. This option is only applicable if `git tag` is used to list tags. + --contains <commit>:: Only list tags which contain the specified commit. diff --git a/builtin/tag.c b/builtin/tag.c index aa1f87d..b74b8bf 100644 --- a/builtin/tag.c +++ b/builtin/tag.c @@ -12,6 +12,7 @@ #include "tag.h" #include "run-command.h" #include "parse-options.h" +#include "column.h" static const char * const git_tag_usage[] = { "git tag [-a|-s|-u <key-id>] [-f] [-m <msg>|-F <file>] <tagname> [<head>]", @@ -22,6 +23,7 @@ static const char * const git_tag_usage[] = { }; static char signingkey[1000]; +static struct column_layout layout; struct tag_filter { const char *pattern; @@ -52,7 +54,7 @@ static int show_reference(const char *refname, const unsigned char *sha1, } if (!filter->lines) { - printf("%s\n", refname); + string_list_append(&layout.items, refname); return 0; } printf("%-15s ", refname); @@ -383,6 +385,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix) OPT_STRING('u', NULL, &keyid, "key-id", "use another key to sign the tag"), OPT__FORCE(&force, "replace the tag if exists"), + OPT_COLUMN(0, "column", &layout, "show tag list in columns" ), OPT_GROUP("Tag listing options"), { @@ -395,6 +398,9 @@ int cmd_tag(int argc, const char **argv, const char *prefix) }; git_config(git_tag_config, NULL); + layout.mode = core_column; + layout.width = term_columns(); + layout.items.strdup_strings = 1; argc = parse_options(argc, argv, prefix, options, git_tag_usage, 0); @@ -413,9 +419,16 @@ int cmd_tag(int argc, const char **argv, const char *prefix) if (list + delete + verify > 1) usage_with_options(git_tag_usage, options); - if (list) - return list_tags(argv[0], lines == -1 ? 0 : lines, + if (list) { + int ret; + + if (lines != -1) + layout.mode = COL_PLAIN; + ret = list_tags(argv[0], lines == -1 ? 0 : lines, with_commit); + display_columns(&layout, 2, ""); + return ret; + } if (lines != -1) die("-n option is only allowed with -l."); if (with_commit) -- 1.7.2.2 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html