Re: Intermittent failures in t9119

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric Wong <normalperson@xxxxxxxx> wrote:
> Junio C Hamano <gitster@xxxxxxxxx> wrote:
> > Eric  Wong <normalperson@xxxxxxxx>  writes:
> > > Junio C Hamano <gitster@xxxxxxxxx> wrote:
> >  >>  (2) Nobody uses the value from "Text Last Updated" field in  practice, 
>so
> > >>      that bug has been unnoticed so  far;
> > >> 
> > >>  (3) And it is not worth fixing it  ;-)
> > >> 
> > >> For now, I would suggest fixing the  failing test to ignore the "Text 
Last
> > >> Updated" field while  comparing, and if somebody is inclined to, we would
> > >> update the  code to match what "svn info" does.
> > >
> > > Agreed on both  points.  I consider "git svn log" and "git svn info" to
> > > be  reasonable approximations of svn behavior, not exact replicas.
> > >  Exactly matching would be extremely difficult given variations between
> >  > different svn versions, and also svn requiring network access while
> >  > git svn does not.
> > 
> > Ok, here is a minimum patch to do  that.
> 
> > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
> 
> Thanks,  Acked-by: Eric Wong <normalperson@xxxxxxxx>


Acked-by: David Kilzer <ddkilzer@xxxxxxxxxx>

Thanks!

Dave

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]