On Sun, Dec 19, 2010 at 06:41:22PM -0800, Junio C Hamano wrote: > > I'm not that familiar with git internals involved, so here is updated > > patch with added paragraph about "df->sha1_valid=0 means files from > > worktree with unknown sha1", and appropriate excerpt from Jeff's post. > > That's the most reasonable I could come up with. > [...] > Here is how I would describe it. > > commit 87bb04bb760659dd33d7a173333329cd900620a9 > Author: Kirill Smelkov <kirr@xxxxxxxxxxxxxxxxxxx> > Date: Sat Dec 18 17:54:12 2010 +0300 > > fill_textconv(): Don't get/put cache if sha1 is not valid > > When blaming files in the working tree, the filespec is marked with > !sha1_valid, as we have not given the contents an object name yet. The > function to cache textconv results (keyed on the object name), however, > didn't check this condition, and ended up on storing the cached result > under a random object name. > > Signed-off-by: Kirill Smelkov <kirr@xxxxxxxxxxxxxxxxxxx> FWIW, I think that is a good description. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html