Jakub Narebski wrote: > Ramsay Jones wrote: >> The first (setup) test attempts to create a file, using the >> test_commit function, called 'i can has snapshot?'. On cygwin >> (and MinGW) this fails with a "No such file or directory" error. >> In order to fix the tests, we simply remove the '?' wildcard >> from the name, since the purpose of these tests is not about >> creating funny filenames. >> >> Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx> > > All right. > > Acked-by: Jakub Narebski <jnareb@xxxxxxxxx> Thanks. > BTW. if the test was about handling funny filenames (containing > leading, embedded and trailing space, +&@=<>"' characters), what > should we do instead? Hmm... dunno; take a look at t3600-rm.sh and t4135-apply-weird-filenames.sh for inspiration? ;-) Just FYI the "illegal" pathname characters in windows include: < > : " / \ | ? * along with control chars from 0 - 31. Also, you can't have any trailing spaces or periods. ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html