Ramsay Jones wrote: > > The first (setup) test attempts to create a file, using the > test_commit function, called 'i can has snapshot?'. On cygwin > (and MinGW) this fails with a "No such file or directory" error. > In order to fix the tests, we simply remove the '?' wildcard > from the name, since the purpose of these tests is not about > creating funny filenames. > > Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx> All right. Acked-by: Jakub Narebski <jnareb@xxxxxxxxx> BTW. if the test was about handling funny filenames (containing leading, embedded and trailing space, +&@=<>"' characters), what should we do instead? > --- > t/t9501-gitweb-standalone-http-status.sh | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/t/t9501-gitweb-standalone-http-status.sh b/t/t9501-gitweb-standalone-http-status.sh > index 2487da1..18825af 100755 > --- a/t/t9501-gitweb-standalone-http-status.sh > +++ b/t/t9501-gitweb-standalone-http-status.sh > @@ -16,7 +16,7 @@ code and message.' > # snapshot settings > > test_expect_success 'setup' " > - test_commit 'SnapshotTests' 'i can has snapshot?' > + test_commit 'SnapshotTests' 'i can has snapshot' > " > > > -- > 1.7.3 > > > -- Jakub Narebski Poland -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html