On Fri, 10 Dec 2010, Junio C Hamano wrote: > Jakub Narebski <jnareb@xxxxxxxxx> writes: >> "John 'Warthog9' Hawley" <warthog9@xxxxxxxxxxxxxx> writes: >>> >>> +# Global declarations >>> +our $cacheFile; >>> +our $cacheFileBG; >>> +our $cacheFileBinWT; >>> +our $cacheFileBin; >> >> You are trading globs for global (well, package) variables. They are >> not lexical filehandles... though I'm not sure if it would be possible >> without restructuring code; note that if variable holding filehandle >> falls out of scope, then file would be automatically closed. > > Hmm. why is it a bad idea, when you need to access these from practically > everywhere, to use global variables to begin with? To a certain degree, > it sounds like an unnecessary burden without much gain to me. If you check my rewrite of gitweb output caching: "[PATCHv6/RFC 00/24] gitweb: Simple file based output caching" http://repo.or.cz/w/git/jnareb-git.git/shortlog/refs/heads/origin..refs/heads/gitweb/cache-kernel-v6 https://github.com/jnareb/git/compare/origin...gitweb/cache-kernel-v6 you would see that I always use lexical filehandles, and I never need to use global variables / glob filehandles. http://en.wikipedia.org/wiki/Global_variables -- Jakub Narebski Poland -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html