Re: [PATCH 12/18] gitweb: Change file handles (in caching) to lexical variables as opposed to globs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb@xxxxxxxxx> writes:

>> +# Global declarations
>> +our $cacheFile;
>> +our $cacheFileBG;
>> +our $cacheFileBinWT;
>> +our $cacheFileBin;
>
> You are trading globs for global (well, package) variables.  They are
> not lexical filehandles... though I'm not sure if it would be possible
> without restructuring code; note that if variable holding filehandle
> falls out of scope, then file would be automatically closed.

Hmm. why is it a bad idea, when you need to access these from practically
everywhere, to use global variables to begin with?  To a certain degree,
it sounds like an unnecessary burden without much gain to me.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]