Anders Kaseorg <andersk@xxxxxxxxxxx> writes: > @@ -44,6 +47,19 @@ static const char *prio_names[] = { > "head", "lightweight", "annotated", > }; > > +static inline unsigned int hash_sha1(const unsigned char *sha1) > +{ > + return *(unsigned int *)sha1; > +} Do we know that all the archs we will be compiled on will be happy with this potentially unaligned access? hash_filespec() in diffcore-rename.c is written in a way to avoid such an issue, and I would feel safer to see this do the same. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html