On Tue, 7 Dec 2010, Junio C Hamano wrote: > I however think this may hurt when more than one objects are asked to be > described and there is no exact match. Yeah, that turns out to be true. So I rewrote the patch to put the commit_names into a hash table instead of a linked list, run replace_name() only once per tag, and run the lookup code only once per describe(). I also tried to split things up a bit more and explain more in the commit messages. > * Please run tests before submitting patches. It appears to break t7407. Oops, I was lazy and only ran the tests that (directly) use describe; Iâll be more careful in the future. The new series doesnât have this problem because it does the replace_name()s in the same order as the old code, and it passes all tests. fixed 1 success 6426 failed 0 broken 39 total 6496 Anders -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html