Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx> writes: > -w3m|links|lynx|open) > +w3m|elinks|links|lynx|open) > eval "$browser_path" "$@" > ;; > start) > exec "$browser_path" '"web-browse"' "$@" > ;; > -dillo) > +opera|dillo) > "$browser_path" "$@" & > ;; Not a complaint on your patch, but is there a reason we say "eval", "exec" and "(nothing)" in these three case arms? The above makes the interpretation of $browser_path and $@ inconsistent between lynx family codepath (which would apply $IFS to find the browser) and dillo and start family codepath (which would not), and I am wondering if that difference is intended. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html