This second issue of the web--browse cleanup and extension patchset has seen some stylistic changes in the first patches as discussed on the ML, and a new patch to add support for the BROWSER env var. Support for xdg-open is still missing, due to the lack of an obvious way to suggest opening pages in new tabs (same reason why we don't directly support Debian's sensible-browser). I'm quite convinced that the first 4 patches (up to the "support opera, seamonkey and elinks" patch, inclusive) are ready for merging. The fifth patch is slightly more extensive than in the previous iteration, including chromium-browser as a supported option, but still looking for chromium-browser first even when browser=chromium. The last two patches are more RFCish. I tried to include the changes suggested by Christian, unless of course I forgot something. Suggestions on possible ways to improve the proposed approach are welcome. Giuseppe Bilotta (7): CodingGuidelines: mention whitespace preferences for shell scripts web--browse: coding style web--browse: split valid_tool list web--browse: support opera, seamonkey and elinks web--browse: better support for chromium web--browse: use (x-)www-browser if available web--browse: look at the BROWSER env var Documentation/CodingGuidelines | 4 + Documentation/git-web--browse.txt | 10 ++ git-web--browse.sh | 276 +++++++++++++++++++++++++------------ 3 files changed, 203 insertions(+), 87 deletions(-) -- 1.7.3.2.664.g294b8.dirty -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html