Giuseppe Bilotta wrote: > --- a/git-web--browse.sh > +++ b/git-web--browse.sh > @@ -138,6 +138,51 @@ then [...] > +if test -z "$browser" -a -n "$BROWSER"; then > + OLDIFS="$IFS" > + IFS=: [...] > + IFS="$OLDIFS" Micronit: on some shells (e.g., old ash[1]), IFS starts out unset if it hasn't been inherited in the environment. How about something like this? LF=" " usual_ifs=" $LF" IFS=: ... IFS=$usual_ifs ... IFS=$usual_ifs Based on [2] I would guess that any POSIX-style shell would also support IFS=: ... unset IFS ... unset IFS but maybe that's playing with fire. The rest of this series looks quite nice, so Acked-by: Jonathan Nieder <jrnieder@xxxxxxxxx> [1] http://bugs.debian.org/95856 [2] http://www.in-ulm.de/~mascheck/various/ifs/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html