Re: [PATCHv3 2/3] cvsimport: fix the parsing of uppercase config options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King <peff@xxxxxxxx> writes:

> If there are short config options that work, though, we should probably
> keep them. It surely can't be that hard for the perl code to accept both
> "cvsimport.r" and "cvsimport.remote" for "-r" and
> "cvsimport.generaterevisions" (or whatever) for "-R"?

I'd agree.  The current parameter set we give to GetOptions is:

    haivmkuo:d:p:r:C:z:s:M:P:A:S:L:R

and I notice that we cannot sanely access A, M, P, R, S and their
lowercase counterparts.

It shouldn't be too hard to interpret the single letter options for the
currently supported set but only for lowercase letters plus '-C <arg>' and
'-L <arg>' (because there are no lowercase ones that crash with them), and
give long config names to at least the ones inaccessible with the above.

Wouldn't that give us a regression-free solution to the immediate problem
at hand?

Supporting long options on the command line, and giving long config name
synonyms to the lowercase ones, would be a plus for consistency's sake,
but that probably is a separate topic.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]