On Sat, Nov 27, 2010 at 6:29 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Even if split up into multiple patches? ÂI don't think it makes much > sense to say "functions in the commit_list API all start with > commit_list_" I didn't say that in the patch. > while at the same time leaving half of the functions in > the commit_list API without that suffix. > What's is the problem with this? I don't see a reason to do this to all the functions in the same time. I prefer to do this in small patches. But it seems Junio is not going to pick this up? > By the way, how did this come up? ÂPresumably some particular code > was confusing? It became with the idea of API, we see this with strbuf and string_list. And this would be good to make the code more easy to read. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html