On Sun, Nov 14, 2010 at 7:19 PM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Thiago Farina wrote: > >> Append commit_lis prefix to insert_by_date function and to sort_by_date, >> so it's clear that these functions refer to commit_list structure. > > Nits: by "Append" I think you mean "Add"; missing "t" after commit_lis. > Thanks, I will fix this in a follow up. > This gives the oft-used insert_by_name() function a fairly long name: > > Â Â Â Âcommit_list_insert_by_name > > The proposed name is long enough to be unwieldly. ÂIt might have > the virtue of fitting better with some of the commit_list lib: > > Â Â Â Âcommit_list_count > Â Â Â Âcommit_list_insert > Â Â Â Âfree_commit_list > > Compare: > > Â Â Â Âsort_by_date > Â Â Â Âpop_most_recent_commit > Â Â Â Âsort_in_topological_order > Â Â Â Âpop_commit > I don't understand what you are arguing here. Is about the size of "commit_list_insert_by_name"? I don't care about it's size, I just want to make it consistent by adding commit_list in the functions that are part of the commit_list API. > Perhaps this change would work better if some of the others were > renamed at the same time? > I don't think so, this would increasing the size of the change and make it less readable. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html