On Mon, Oct 11, 2010 at 12:16 AM, Erik Faye-Lund <kusmabite@xxxxxxxxx> wrote: > On Sun, Oct 10, 2010 at 11:28 PM, Eric Sunshine <ericsunshine@xxxxxxxxx> wrote: >> On 10/10/2010 4:37 PM, Erik Faye-Lund wrote: >>> Are you suggesting that we report an error when we can't report the >>> string correctly? We could do that, but I'm not sure how the end-user >>> would benefit from that. ReportEvent is used to report errors (unless >>> the --verbose flag has been specified), and reporting that we can't >>> present an error message strike me as a bit confusing... Even the >>> corrupted error message is probably better :P >> >> I am not suggesting reporting an error. As a first-time reader of the code, >> I was trying to understand the presence of the comment which did not really >> seem to relate to the code. Perhaps adding a "FIXME" to the comment saying >> that the condition should perhaps be handled in the future would help to >> explain the comments presence. >> > > A FIXME would certainly a good idea, if I don't just end up supporting > varargs here. > Uhm, excuse me for confusing the different comments :P Yes, a FIXME should definitely be added. And I definitely need to seep now! ;) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html