On Mon, Oct 4, 2010 at 09:21, Ãvar ArnfjÃrà Bjarmason <avarab@xxxxxxxxx> wrote:
> Wrap "S_IFREG | 0644" in parentheses to avoid a "suggest parentheses
> around arithmetic in operand of |" warning from GCC 4.1.3 on NetBSD
> 5.0.2.
>
> I spotted and fixed this independently on NetBSD, but later found that
> there was a NetBSD Problem Report that included this fix.
With this and Jonathan's xdiff patch git compiles without warnings on
NetBSD, aside from this:
imap-send.c: In function 'ssl_socket_connect':
imap-send.c:310: warning: assignment discards qualifiers from
pointer target type
imap-send.c:312: warning: assignment discards qualifiers from
pointer target type
I don't see a sane way around that[1], since it appears the NetBSD
people have patched openssl's function definitions without bumping the
OpenSSL version number. Either that or OpenSSL itself changed from
const char* to char* to const char* again, I didn't investigate that.
But tests on NetBSD with /bin/sh still fail since we use cd -P, but we
have unapplied patches for that so I didn't pursue it:
http://article.gmane.org/gmane.comp.version-control.git/136561/match=
http://article.gmane.org/gmane.comp.version-control.git/136562/match=
1. We could check for __NetBSD__ and the NetBSD version, but it's not
worthwhile for a single warning.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html