Wrap "S_IFREG | 0644" in parentheses to avoid a "suggest parentheses around arithmetic in operand of |" warning from GCC 4.1.3 on NetBSD 5.0.2. I spotted and fixed this independently on NetBSD, but later found that there was a NetBSD Problem Report that included this fix. NetBSD-PR: http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=42168 Reported-by: Dan McMahill <dmcmahill@xxxxxxxxxx> Signed-off-by: Ãvar ArnfjÃrà Bjarmason <avarab@xxxxxxxxx> --- builtin/diff.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/builtin/diff.c b/builtin/diff.c index a43d326..e8b7e09 100644 --- a/builtin/diff.c +++ b/builtin/diff.c @@ -93,7 +93,7 @@ static int builtin_diff_blobs(struct rev_info *revs, int argc, const char **argv, struct blobinfo *blob) { - unsigned mode = canon_mode(S_IFREG | 0644); + unsigned mode = canon_mode((S_IFREG | 0644)); if (argc > 1) usage(builtin_diff_usage); -- 1.7.3.159.g610493 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html