Re: [PATCHv5 15/16] Add missing &&'s throughout the testsuite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Elijah Newren <newren@xxxxxxxxx> writes:

> On Sun, Oct 3, 2010 at 8:46 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
>>> --- a/t/t1509-root-worktree.sh
>>> +++ b/t/t1509-root-worktree.sh
>>> @@ -232,8 +232,8 @@ say "auto bare gitdir"
>>>
>>>  # DESTROYYYYY!!!!!
>>>  test_expect_success 'setup' '
>>> -     rm -rf /refs /objects /info /hooks
>>> -     rm /*
>>> +     rm -rf /refs /objects /info /hooks &&
>>> +     rm /* &&
>>
>> I'm worried that this would fail:
>>
>>        $ mkdir foo
>>        $ cd foo
>>        $ >bar
>>        $ mkdir baz
>>        $ rm *
>>        rm: cannot remove `baz': Is a directory
>>        $ echo $?
>>        1
>
> How about replacing the two rm commands with a simple 'rm -rf /*'?

How would "rm -rf /*" that will remove /bin/sh and /usr/bin/git among
other things would possibly help?  Isn't this test about having a minimum
chroot with /bin, /usr populated with minimum git (and presumably shell
tools) and for whatever sick reason have a bare git repository at /?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]