On Sun, Oct 3, 2010 at 8:46 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: >> --- a/t/t1509-root-worktree.sh >> +++ b/t/t1509-root-worktree.sh >> @@ -232,8 +232,8 @@ say "auto bare gitdir" >> >> Â# DESTROYYYYY!!!!! >> Âtest_expect_success 'setup' ' >> - Â Â rm -rf /refs /objects /info /hooks >> - Â Â rm /* >> + Â Â rm -rf /refs /objects /info /hooks && >> + Â Â rm /* && > > I'm worried that this would fail: > > Â Â Â Â$ mkdir foo > Â Â Â Â$ cd foo > Â Â Â Â$ >bar > Â Â Â Â$ mkdir baz > Â Â Â Â$ rm * > Â Â Â Ârm: cannot remove `baz': Is a directory > Â Â Â Â$ echo $? > Â Â Â Â1 How about replacing the two rm commands with a simple 'rm -rf /*'? > Â Â Â Âtest_expect_success 'did not use upload-pack service' ' > Â Â Â Â Â Â Â Â! grep '/git-upload-pack' <"$HTTPD_ROOT_PATH"/access.log > Â Â Â Â' > > This way, (like before) one would get to see the git-upload-pack lines > when the test fails while running with -v. Make sense. >> - Â Â ln -s docs/manual.txt src/part4.c >> + Â Â ln -s docs/manual.txt src/part4.c && >> Â Â Â git clean && >> Â Â Â test -f Makefile && >> Â Â Â test -f README && > > Missing SYMLINKS prereq? Indeed. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html