Hi, On Wed, Sep 29, 2010 at 1:01 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Also add a test_might_fail in front of the final git_config --unset >> core.whitespace as that value may have already been unset previously. > > In general, if a previous one that is designed to set a variable failed > for whatever reason, the next one that does --unset without might-fail > will be broken. ÂSo... > [...] >> + Â Â git config --unset core.whitespace && > > ... I think you need might-fail in front of this one, and ... [...] > >> + Â Â echo "F whitespace=-space" >.gitattributes && >> + Â Â prepare_output && >> >> Â Â Â grep Eight normal >/dev/null && >> Â Â Â grep HT normal >/dev/null && >> @@ -107,9 +107,9 @@ test_expect_success 'without -space (attribute)' ' >> >> Âtest_expect_success 'with indent-non-tab only' ' >> >> - Â Â rm -f .gitattributes >> - Â Â git config core.whitespace indent,-trailing,-space >> - Â Â prepare_output >> + Â Â rm -f .gitattributes && >> + Â Â git config core.whitespace indent,-trailing,-space && > > ... this one, ... I fixed the others you pointed out, but elsewhere you were talking about git config --unset and the --unset option is not being used here. Is there another reason this config command needs one? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html