Elijah Newren wrote: > --- a/t/t4019-diff-wserror.sh > +++ b/t/t4019-diff-wserror.sh > @@ -40,7 +40,7 @@ prepare_output () { > > test_expect_success default ' > > - prepare_output > + prepare_output && The exit status from prepare_output is the exit status from its last command, which is "grep -v <something blue>". It seems that never fails in these test cases, but should we be relying on that? (I haven't thought hard about the answer. If we shouldn't be, a workaround could look like this.) diff --git a/t/t4019-diff-wserror.sh b/t/t4019-diff-wserror.sh index 36f06c7..afd74c8 100755 --- a/t/t4019-diff-wserror.sh +++ b/t/t4019-diff-wserror.sh @@ -36,6 +36,7 @@ prepare_output () { git diff --color >output $grep_a "$blue_grep" output >error $grep_a -v "$blue_grep" output >normal + : } test_expect_success default ' -- -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html