On Thu, Sep 30, 2010 at 01:42:53PM +0000, Ãvar ArnfjÃrà Bjarmason wrote: > As threatened here's a series that cleans up some of the glaring warts > in git-send-email. > > Ãvar ArnfjÃrà Bjarmason (16): > send-email: use lexical filehandle for opendir > send-email: use lexical filehandles for $compose > send-email: use lexical filehandles during sending > send-email: get_patch_subject doesn't need a prototype > send-email: file_declares_8bit_cte doesn't need a prototype > send-email: unique_email_list doesn't need a prototype > send-email: cleanup_compose_files doesn't need a prototype > send-email: use \E***\Q instead of \*\*\* > send-email: sanitize_address use $foo, not "$foo" > send-email: sanitize_address use qq["foo"], not "\"foo\"" > send-email: use (?:) instead of () if no match variables are needed > send-email: is_rfc2047_quoted use qr// regexes > send-email: extract_valid_address use qr// regexes and /o > send-email: send_message die on $!, not $? > send-email: make_message_id use "require" instead of "use" > send-email: use Perl idioms in while loop With the exception of my comments on the "/o" regexes, these all look sane to me. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html