On Thu, Sep 30, 2010 at 9:42 AM, Ãvar ArnfjÃrà Bjarmason <avarab@xxxxxxxxx> wrote: > As threatened here's a series that cleans up some of the glaring warts > in git-send-email. > > Ãvar ArnfjÃrà Bjarmason (16): > Âsend-email: use lexical filehandle for opendir > Âsend-email: use lexical filehandles for $compose > Âsend-email: use lexical filehandles during sending > Âsend-email: get_patch_subject doesn't need a prototype > Âsend-email: file_declares_8bit_cte doesn't need a prototype > Âsend-email: unique_email_list doesn't need a prototype > Âsend-email: cleanup_compose_files doesn't need a prototype > Âsend-email: use \E***\Q instead of \*\*\* > Âsend-email: sanitize_address use $foo, not "$foo" > Âsend-email: sanitize_address use qq["foo"], not "\"foo\"" > Âsend-email: use (?:) instead of () if no Âmatch variables are needed > Âsend-email: is_rfc2047_quoted use qr// regexes > Âsend-email: extract_valid_address use qr// regexes and /o > Âsend-email: send_message die on $!, not $? > Âsend-email: make_message_id use "require" instead of "use" > Âsend-email: use Perl idioms in while loop > > Âgit-send-email.perl  |  80 +++++++++++++++++++++++------------------------- > Ât/t9001-send-email.sh |  Â2 +- > Â2 files changed, 39 insertions(+), 43 deletions(-) These all look pretty uncontroversial and sane by me, though I don't think you touched any of the lines I contributed to git-send-email. If anything, perhaps this series is a bit too granular -- I might combine the commits that get rid of the function prototypes into one for example. Otherwise, thanks for the cleanup. Acked-by: Jay Soffian <jaysoffian@xxxxxxxxx> j. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html