On Tue, Sep 28, 2010 at 8:20 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Nguyán ThÃi Ngác Duy Â<pclouds@xxxxxxxxx> writes: > >> This function can be potentially used in more places than just >> tree-diff.c. "struct diff_options" does not make much sense outside >> diff_tree_sha1(). > > This does a bit more than that; it does not call tree_entry_extract() > anymore, and instead uses the knowledge of its underlying implementation. > The mode of the entry that is passed to S_ISDIR() check is not cleansed > with canon_mode() anymore. Hmm.. missed that. Thanks for catching. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html