Nguyán ThÃi Ngác Duy <pclouds@xxxxxxxxx> writes: > This function can be potentially used in more places than just > tree-diff.c. "struct diff_options" does not make much sense outside > diff_tree_sha1(). This does a bit more than that; it does not call tree_entry_extract() anymore, and instead uses the knowledge of its underlying implementation. The mode of the entry that is passed to S_ISDIR() check is not cleansed with canon_mode() anymore. I do not think these are necessarily bad changes, but they should be documented. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html