On Fri, Sep 24, 2010 at 16:06, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Fri, 2010-09-24 at 08:32 -0700, Jakub Narebski wrote:
>> Joe Perches <joe@xxxxxxxxxxx> writes:
>> > +# Execute a command (ie: $to_cmd) to get a list of email addresses
>> > +# and return a results array
>> > +sub recipients_cmd(@) {
>> Do not use subroutine prototypes: they do not do what you think they
>> do. ÂIn this case using prototype is unnecessary and can be dangerous.
>
> It can be removed. ÂI was following the form of the
> other returned array in the code.
While we generally follow the rule that you should use the style of
the existing code, I think resaonable to discard that when the
surrounding code with less than wizard-level understanding of the
language.
In any case most of git-send-email.perl doesn't use prototypes, it's
just 2-3 subs out of ~30.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html