On Thu, Sep 23, 2010 at 17:46, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Thu, 2010-09-23 at 17:29 +0000, Ãvar ArnfjÃrà Bjarmason wrote:
>> On Thu, Sep 23, 2010 at 17:17, Joe Perches <joe@xxxxxxxxxxx> wrote:
>> > I know there's a test harness in git, but
>> > I don't know how to wire up the new options.
>> You'd add the tests to t9001-send-email.sh and --tocmd out to some
>> program you create. Is there anything in particular you need help
>> with?
>
> Just the doing. ÂI was (am) being lazy.
>
>> > -if (!@to) {
>> > +if (!@to && $to_cmd eq "") {
>>
>> Why compare $to_cmd to "" instead of checking definedness?
>
> No real reason. ÂUsing define is the style used in the rest of
> the file and it should be changed.
>
>> > @@ -1238,6 +1242,23 @@ foreach my $t (@files) {
>> > Â Â Â Â}
>> > Â Â Â Âclose F;
>> >
>> > + Â Â Â if (defined $to_cmd) {
>> > + Â Â Â Â Â Â Â open(F, "$to_cmd \Q$t\E |")
>>
>> quotemeta() is for escaping regexes, not shell syntax. You probably
>> want IPC::Open2 or PC::Open3's functions which'll escape arguments for
>> you.
>
> I just copied the style from the equivalent cc_cmd section below,
> so if it's necessary, it should be changed there too.
>
>> I.e. do you need to strip whitespace from the beginning of the string?
>
> I think so.
This all sounds reasonable, but I really need to go through
git-send-email.perl and fix all these bugs at some point...
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html