On Thu, Sep 16, 2010 at 12:19 PM, Ævar Arnfjörð Bjarmason
<avarab@xxxxxxxxx> wrote:
> On Thu, Sep 16, 2010 at 09:31, Giuseppe Bilotta
> <giuseppe.bilotta@xxxxxxxxx> wrote:
>
>> + if (@remotelist) {
>> + git_print_header_div('remotes');
>> + git_heads_body(\@remotelist, $head, 0, 15,
>> + $#remotelist <= 15 ? undef :
>> + $cgi->a({-href => href(action=>"remotes")}, "..."));
>> + }
>
> Nit: The $# syntax is pseudo-deprecated, and since you use 16 as a
> constant above this would be clearer anyway:
>
> @remotelist <= 16 ? undef : ...
I think following the gitweb coding style is better. OTOH, I can
probably prepare a (separate) patch to replace $# with @ where
possible.
--
Giuseppe "Oblomov" Bilotta
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html