Re: [PATCH 2/2] log --author: take union of multiple "author" requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 13, 2010 at 4:18 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>    log --author=me --author=her \
>        --committer=him --committer=you \
>        --grep=this --grep=that
>
> into
>
>    (ALL-MATCH
>      (OR (HEADER-AUTHOR me) (HEADER-AUTHOR her))
>      (OR (HEADER-COMMITTER him) (HEADER-COMMITTER you))
>      (OR (PATTERN this) (PATTERN that)))

Both patches look good to me.  Tested fine with my use cases. Thanks
for doing this.

I'm a little confused about the implementation with regards to
--all-match; does there still need to be an all-match flag?  Seems
like it has now been deprecated (to being, essentially, the default).
In any case, there should also probably something going along with
this patch series to update Documentation/rev-list-options.txt.

Thanks again.

-- 
Emil Sit / http://www.emilsit.net/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]