On Sun, Sep 5, 2010 at 15:06, Thiago Farina <tfransosi@xxxxxxxxx> wrote:
> Hi Ramana,
>
> Some *style* comments below.
> On Sun, Sep 5, 2010 at 6:53 AM, Ramana Kumar <ramana.kumar@xxxxxxxxx> wrote:
>> fprintf(fp,
>> "\n"
>> "# Please enter the commit message for your changes.");
>> - if (cleanup_mode == CLEANUP_ALL)
>> + if (cleanup_mode == CLEANUP_ALL && !verbose)
>> fprintf(fp,
>> " Lines starting\n"
>> "# with '#' will be ignored, and an empty"
>> " message aborts the commit.\n");
> The Documentation/CodingStyle says to avoid using braces unncessary.
> But since this is not a single line statement, like:
> if (foo)
> foo = x;
>
> Could you wrapp this into { } ?
The braces are still unncessary if the function call is spread across
a few lines. I haven't seen anything in the source that indicates that
we prefer braces when a braceless if/else has an associated statement
that exceeds 1 line.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html