Re: [PATCH] tests: fix syntax error in "Use advise() for hints" test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes:

> On Fri, Aug 20, 2010 at 10:13, Raja R Harinath <harinath@xxxxxxxxxxxx> wrote:
>> Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes:
>>
>>> On Thu, Aug 19, 2010 at 04:30, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
>> [snip]
>>>> Although the style you chose is arguably the least ugly, nested shell
>>>> interpolation can be hard to follow.  How about this?
>>>
>>> I think '\'' is harder to follow than \" and \$, but each to his own
>>> :)
>>
>> There's also the slightly longer but somewhat prettier '"'"'.
>
> I must say, you guys have an odd sense of aesthetics :)

I'd have to agree.  If I were writing this I would probably use '\''
myself but that is not because it looks good (it does not) but in my
experience it tends to be the least error prone.

But your original is just fine.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]