On Thu, Aug 19, 2010 at 04:30, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> Ævar Arnfjörð Bjarmason wrote:
>
>> Change the test introduced in the "Use advise() for hints" patch by
>> Jonathan Nieder not to use '' for quotes inside '' delimited code.
>
> Yikes. Thanks for catching this.
FWIW prove flagged it:
$ prove ./t35*.sh
./t3500-cherry.sh .................... ok
./t3501-revert-cherry-pick.sh ........ ok
./t3502-cherry-pick-merge.sh ......... ok
./t3503-cherry-pick-root.sh .......... ok
./t3504-cherry-pick-rerere.sh ........ ok
./t3505-cherry-pick-empty.sh ......... ok
./t3506-cherry-pick-ff.sh ............ ok
./t3507-cherry-pick-conflict.sh ...... 1/?
./t3507-cherry-pick-conflict.sh: 59: cannot open paths: No such file
./t3507-cherry-pick-conflict.sh ...... ok
./t3508-cherry-pick-many-commits.sh .. ok
./t3509-cherry-pick-merge-df.sh ...... ok
All tests successful.
Files=10, Tests=62, 4 wallclock secs ( 0.08 usr 0.06 sys + 0.65
cusr 2.91 csys = 3.70 CPU)
Result: PASS
> Although the style you chose is arguably the least ugly, nested shell
> interpolation can be hard to follow. How about this?
I think '\'' is harder to follow than \" and \$, but each to his own
:)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html