Sverre Rabbelier wrote:
> On Tue, Aug 17, 2010 at 01:54, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
>> -test_debug 'gitk --all'
>> +test_debug 'git log --graph --decorate --oneline --all'
>
>> -test_debug 'gitk --all'
>> +test_debug 'git log --graph --decorate --oneline --all'
[...]
> Really? Why can't you stuff the command to execute in a variable? On
> that note, why wasn't that done in the first place?! This kind of
> repetition is not very DRY.
My thought was that
test_debug '$debug_command'
...
test_debug '$debug_command'
...
[etc]
is not very DRY either, so I am hoping some configurable version of
-- 8< --
diff --git a/t/test-lib.sh b/t/test-lib.sh
index e8f21d5..65b0e35 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -373,6 +373,7 @@ test_run_ () {
if test "$verbose" = "t" && test -n "$HARNESS_ACTIVE"; then
echo ""
fi
+ test_debug "git log --graph --decorate --oneline --all"
return 0
}
-- >8 --
appears to replace it. In the short term, the "s/gitk --all/git log
--graph --decorate --oneline --all/" was just meant as a quick fix
so as not to drop the feature. Ideas?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html