Re: [PATCH 03/24] t7600 (merge): do not launch gitk for --debug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Heya,

On Tue, Aug 17, 2010 at 01:54, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> -test_debug 'gitk --all'
> +test_debug 'git log --graph --decorate --oneline --all'


> -test_debug 'gitk --all'
> +test_debug 'git log --graph --decorate --oneline --all'

> -test_debug 'gitk --all'
> +test_debug 'git log --graph --decorate --oneline --all'

Really? Why can't you stuff the command to execute in a variable? On
that note, why wasn't that done in the first place?! This kind of
repetition is not very DRY.

-- 
Cheers,

Sverre Rabbelier
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]