Re: [RFC/PATCHv2] t5525: test the tagopt variable and that it can be overridden

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 13 August 2010 17:39:04 Ævar Arnfjörð Bjarmason wrote:
> On Fri, Aug 13, 2010 at 21:27, Daniel Johnson <computerdruid@xxxxxxxxx> 
wrote:
> > ---
> > 
> >>> @@ -0,0 +1,44 @@
> >>> +
> >>> +#!/bin/sh
> >> 
> >> Is that an empty line before the test begins? The shebang should be on
> >> the first line.
> > 
> > Embarrassing. That's what I get for using yank/put and not paying closer
> > attention. The rest is fixed too.
> 
> Nice, I haven't actually *run it* but it looks good, so provided that
> it passes tests when our beloved maintainer applies it:
> 
> Reviewed-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>

Well, now that we have a fix and a test to help guard against future breakages, 
can someone tell me the next step as to getting them included?

Thanks,
-Dan

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]