Re: [RFC/PATCHv2] t5525: test the tagopt variable and that it can be overridden

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 13, 2010 at 21:27, Daniel Johnson <computerdruid@xxxxxxxxx> wrote:
> ---
>>> @@ -0,0 +1,44 @@
>>> +
>>> +#!/bin/sh
>>
>> Is that an empty line before the test begins? The shebang should be on
>> the first line.
> Embarrassing. That's what I get for using yank/put and not paying closer
> attention. The rest is fixed too.

Nice, I haven't actually *run it* but it looks good, so provided that
it passes tests when our beloved maintainer applies it:

Reviewed-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]