On Tue, Aug 10, 2010 at 20:29, Sverre Rabbelier <srabbelier@xxxxxxxxx> wrote: > Heya, > > On Tue, Aug 10, 2010 at 14:56, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: >> The git-notes expensive timing test is only expensive because it >> either did 1k iterations or nothing. Change it to do 10 by default, >> with an option to run the expensive version with the old >> GIT_NOTES_TIMING_TESTS=ZomgYesPlease variable. > > Nice, why 10 though? Any motivation for that particular value? The old version had "for count in 10 100 1000 10000; do". Mine has 10 as non-expensive, and "for count in 100 1000 10000; do" as expensive. I.e. I'm running the first test batch from the old tests. I have no idea whether it actually needs to run 10..10k times, I didn't try to grok the actual test code. >> The old version would also mysteriously fail on systems without >> /usr/bin/time, there's now a check for that using the test >> prerequisite facility. > > Should this patch be split up? It all touched the same bits, it'd be nastier to split it up IMO. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html