Re: [PATCH] git-notes: Run partial expensive test everywhere

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Heya,

On Tue, Aug 10, 2010 at 14:56, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote:
> The git-notes expensive timing test is only expensive because it
> either did 1k iterations or nothing. Change it to do 10 by default,
> with an option to run the expensive version with the old
> GIT_NOTES_TIMING_TESTS=ZomgYesPlease variable.

Nice, why 10 though? Any motivation for that particular value?

> Since nobody was ostensibly running this test under TAP the code had
> bitrotted so that it emitted invalid TAP. This change fixes that.

Nice catch.

> The old version would also mysteriously fail on systems without
> /usr/bin/time, there's now a check for that using the test
> prerequisite facility.

Should this patch be split up?

-- 
Cheers,

Sverre Rabbelier
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]