On Wed, Jul 21, 2010 at 00:14, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Ævar Arnfjörð Bjarmason wrote: > >> We should have examples for both export and unset > > What is unportable for “export” is the effect of exporting an unset > variable. I am not even sure whether the return value is unportable, > but it doesn’t matter; that is an example of a “Don’t” rather than a > “Do it this way”. I didn't know that. It'd be good if it were mentioned in the docs. I thought it was just export in general. > See v1.5.6-rc0~61 (filter-branch: fix variable export logic, > 2008-05-13) for an example. As an aside, how do you make these 61-commits-after-rc0 commit ids. Is there a sha1->that tool that I haven't spotted? >> but the prose >> should mention both IMO > > Yes, thanks for putting this portability guide together. Thanks for improving it, this change is a definite improvement, I just had a "wait, what's the export doing there then?" question when reading it. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html