On 07/20/2010 03:49 PM, Ævar Arnfjörð Bjarmason wrote:
> On Tue, Jul 20, 2010 at 19:16, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
>> Ęvar Arnfjörš Bjarmason wrote:
>>
>>> That's what we seem to be doing in the tests so far, i.e. test_must_fail
>>> is reserved for git commands only.
>> test_must_fail relies on conventions for return value that cannot
>> necessarily be relied on from outside utilities.
>
> Right, someone should send a patch for these:
>
> ack 'test_must_fail (?!git)' *sh
>
> :)
You joke, but thanks to your prodding, I discovered these broken
tests that should definitely all be fixed:
$ perl -ne 'm/test_must_fail +[^ ]+=/ && print' *sh
test_must_fail PAGER= git reflog show delta &&
test_must_fail PAGER= git reflog show epsilon &&
test_must_fail PAGER= git reflog show epsilon
test_must_fail PAGER= git reflog show zeta &&
test_must_fail PAGER= git reflog show eta &&
test_must_fail PAGER= git reflog show eta
test_must_fail PAGER= git reflog show beta
test_must_fail MSG="yet another note" git notes add -c deadbeef &&
one-shot variable assignment does not work with test_must_fail.
See e2007832552ccea9befed9003580c494f09e666e for an explanation.
-brandon
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html