Re: [PATCH] t/: work around one-shot variable assignment with test_must_fail

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 20, 2010 at 23:44, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote:
> On Tue, Jul 20, 2010 at 21:55, Brandon Casey <casey@xxxxxxxxxxxxxxx> wrote:
>
>> -       test_must_fail PAGER= git reflog show delta &&
>> +       (
>> +               PAGER= &&
>> +               export PAGER &&
>> +               test_must_fail git reflog show delta
>> +       ) &&
>
> You must use "export PAGER;", not "export PAGER &&". export doesn't
> return zero on all systems when exporting, see previous changes in
> this regard in t/.

Actually, see the t/README docs which explicitly mention this. Yay docs.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]