On Wed, Jul 07, 2010 at 02:44:50PM -0700, Jakub Narebski wrote: > > Oh, makes sense. Thanks. So that's a quite troubling corner case... > > I wonder if empty files shouldn't be special cased... > > Well, similarity score (of contents and of filename) is weighted by > contents length, but perhaps empty files / zero length somehow fall > out as an edge case... Exact rename detection is handled before inexact detection, so the contents length are irrelevant. So it is not about empty files, but about exact matches. I'm not sure if the basename-matching code is used for exact matches, though. But ideally we would break exact-match ties based on filename. I'd have to read through the code and/or perform some tests to be sure, though. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html