Re: What's cooking in git.git (Jun 2010, #02; Wed, 16)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Clément Poulain <clement.poulain@xxxxxxxxxxxxxxx> writes:

> A fix was proposed here:
> http://mid.gmane.org/1276610328-28532-1-git-send-email-axel.bonnet@xxxxxxxxxxxxxxx

This one changes textconv_object() to take a pointer to ulong*; a caller
is changed to cast a long* down to that pointer (in fill_origin_blob);
that is shifting one type-punned pointer problem to another one, so I do
not think it is an improvement.

> http://mid.gmane.org/1276617028-5265-1-git-send-email-clement.poulain@xxxxxxxxxxxxxxx

... and this depends on that.

The solution should be along the lines of what Jeff outlined in 

    Message-ID: <20100615110710.GA1682@xxxxxxxxxxxxxxxxxxxxx>

i.e.

    The only portable way in C to convert between types is by assignment. So
    you have to do:

      unsigned long foo;
      textconv_object(read_from, null_sha1, &buf.buf, &foo);
      buf.len = foo;

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]