Axel Bonnet <axel.bonnet@xxxxxxxxxxxxxxx> writes:
> Test the correct functionning of textconv with blame <file> and blame HEAD^ <file>.
> Test the case when no driver is specified.
Good to see tests for both positive and negative cases. Too many people
forget the latter.
> +find_blame() {
> + sed -e 's/^.*(/(/g'
> +}
Two issues:
- No need for "g" as your pattern is anchored at the left;
- As ".*" is greedy, you will eat a lot more than what you expect when
the line in the blamed contents happen to have '(' on it.
I'd rewrite it as:
sed -e 's/^[^(]*//'
Will queue all three patches, with this fix and a style fix for 2/3; no
need to resend.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html