Ævar Arnfjörð Bjarmason wrote:
> On Sat, Jun 5, 2010 at 03:01, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
>> #ifdef NO_GETTEXT
>> static inline void git_setup_gettext(void) {}
>> #endif
>>
>> and
>>
>> ifndef NO_GETTEXT
>> LIB_OBJS += gettext.o
>> endif
>
> Sure, but that would be putting code in a header file, which is
> usually taboo. It looks like there's some prior art on that though.
> Like strbuf.h.
>
> I don't care either way, what do you think?
This is what ‘inline’ is for. I think using it for stubs like this
is perfectly acceptable and improves readability.
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html