On Sat, Jun 5, 2010 at 03:01, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
>> diff --git a/gettext.c b/gettext.c
>> new file mode 100644
>> index 0000000..22cdcc1
>> --- /dev/null
>> +++ b/gettext.c
>> @@ -0,0 +1,25 @@
>> +#ifdef NO_GETTEXT
>> +void git_setup_gettext(void) {}
>> +#else
>> +#include "exec_cmd.h"
>> +#include <libintl.h>
>> +#include <stdlib.h>
>> +
>> +void git_setup_gettext(void) {
> [...]
>
> Could this conditional be taken care of by gettext.h and the Makefile
> and avoid complicating the main source file? i.e., something like
>
> #ifdef NO_GETTEXT
> static inline void git_setup_gettext(void) {}
> #endif
>
> and
>
> ifndef NO_GETTEXT
> LIB_OBJS += gettext.o
> endif
Sure, but that would be putting code in a header file, which is
usually taboo. It looks like there's some prior art on that though.
Like strbuf.h.
I don't care either way, what do you think?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html