On 06/02/2010 01:37 AM, Johannes Sixt wrote: > Am 6/2/2010 2:13, schrieb Brandon Casey: >> +if ! test_have_prereq PYTHON_2_5_OR_NEWER >> then >> + say 'skipping git remote-testgit tests: requires Python 2.5 or newer' > ... >> +++ b/t/test-lib.sh >> +if test_have_prereq PYTHON && "$PYTHON_PATH" -c ' >> +import sys >> +if sys.hexversion < 0x02050000: >> + sys.exit(1) >> +' >> +then >> + test_set_prereq PYTHON_2_5_OR_NEWER >> +fi > > Please don't burden all test script invocations with this check when the > result is used in only one place. Very good point. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html