Re: [PATCH 1/5] t/t5800: skip if python version is older than 2.5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 6/2/2010 2:13, schrieb Brandon Casey:
> +if ! test_have_prereq PYTHON_2_5_OR_NEWER
>  then
> +	say 'skipping git remote-testgit tests: requires Python 2.5 or newer'
...
> +++ b/t/test-lib.sh
> +if test_have_prereq PYTHON && "$PYTHON_PATH" -c '
> +import sys
> +if sys.hexversion < 0x02050000:
> +    sys.exit(1)
> +'
> +then
> +	test_set_prereq PYTHON_2_5_OR_NEWER
> +fi

Please don't burden all test script invocations with this check when the
result is used in only one place.

-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]