Re: [PATCH 2/2] decode file:// and ssh:// URLs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 23, 2010 at 05:19:44AM -0400, Jeff King wrote:
> We generally treat these as equivalent to "/path/to/repo"
> and "host:path_to_repo" respectively. However, they are URLs
> and as such may be percent-encoded. The current code simply
> uses them as-is without any decoding.
> 
> With this patch, we will now percent-decode any file:// or
> ssh:// url (or ssh+git, git+ssh, etc) at the transport
> layer. We continue to treat plain paths and "host:path"
> syntax literally.
> 
> Signed-off-by: Jeff King <peff@xxxxxxxx>
> ---
> I think this also impacts git:// URLs. Which I is probably a good thing,
> but I haven't looked extensively for unexpected fallouts.

One possible fallout: IPv6 scope syntax uses literal '%' in host
part. The relevant RFC indicates it should be escaped, but in the past
connect would fail if it was... But then, who uses that syntax...

-Ilari
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]